Allow watch streaming option for lister watcher to prevent high memory spike.#1038
Merged
zkdlin211 merged 4 commits intoGoogleCloudPlatform:masterfrom Jan 12, 2026
Merged
Conversation
| // Manually pass to handler since we bypass Reflector's store | ||
| config.Handler.OnAdd(e) | ||
| } | ||
| case watch.Bookmark: |
Contributor
There was a problem hiding this comment.
Should we set AllowWatchBookmarks: true in the options?
Contributor
Author
There was a problem hiding this comment.
done, also added according handling logic
yungdarek122
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than ignore the previous unhandled events completely in #1027, which can cause event loss. This memory optimize approach load the event one by one to prevent memory spike if the number of accumulated events are large.